-
Notifications
You must be signed in to change notification settings - Fork 9
Initial work on Common OS skeleton #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...to thwart shadow dom and inheritance issues
- Allows setting activated state on button
- Hide menu button when sidebar is shown - Use close button for sidebar close - Introduce `.fade` utility class - Restructure menu items to bring more of it "in house" and under the direct control of os-scene
Introduce ResponsiveElement helper class which uses a resize observer to generate breakpoint information about the container context. This is to work around the fact that container queries are currently broken for slotted content. The spec is updated and browsers are fixing it, but it's going to be a bit before there is broad support for slotted container queries. See https://chromestatus.com/feature/5242724333387776
Navstack pushes groups of panels without any animation, but dismisses them with a back-stack-like slide-off-of-screen animation. - Introduce animation utils - Remove os-toolbar, move .toolbar to shared styles. We ended up needing this flexibility. - Introduce navpanel as a scrollable content view with a toolbar.
...also add AI icon placeholder.
Splits sidebar 50/50. Switched from ResponsiveElement to container queries for sidebar. This works here because we aren't cuing off of slotted content. Allows us to remove the workaround for the first render animation glitch. Simpler all around.
And fix width at 756, which I think should be enough for 80 columns in the editor. If not, we'll adjust.
...and fix shadow var.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stubbing out basic components for app skeleton and sidebar.
Fixes #164