Skip to content

Conversation

@gordonbrander
Copy link
Contributor

@gordonbrander gordonbrander commented Sep 26, 2024

Stubbing out basic components for app skeleton and sidebar.

  • Components make no assumptions about state management.
  • All interaction exposed as properties
    • Some basic interaction such as sidebar show/hide and modal esc-to-close are implemented as part of the component behavior exposed as properties.
  • Doing a pixel-faithful implementation of the wireframes until we have a VisD to implement. The components liberally use CSS vars to make re-theming easier later.

Fixes #164

@gordonbrander gordonbrander mentioned this pull request Sep 26, 2024
29 tasks
...to thwart shadow dom and inheritance issues
- Allows setting activated state on button
- Hide menu button when sidebar is shown
- Use close button for sidebar close
- Introduce `.fade` utility class
- Restructure menu items to bring more of it "in house" and under the
  direct control of os-scene
Introduce ResponsiveElement helper class which uses a resize observer to
generate breakpoint information about the container context. This is to
work around the fact that container queries are currently broken for
slotted content. The spec is updated and browsers are fixing it, but
it's going to be a bit before there is broad support for slotted
container queries.

See https://chromestatus.com/feature/5242724333387776
Navstack pushes groups of panels without any animation, but dismisses
them with a back-stack-like slide-off-of-screen animation.

- Introduce animation utils
- Remove os-toolbar, move .toolbar to shared styles. We ended up needing
  this flexibility.
- Introduce navpanel as a scrollable content view with a toolbar.
...also add AI icon placeholder.
Splits sidebar 50/50.

Switched from ResponsiveElement to container queries for sidebar. This
works here because we aren't cuing off of slotted content. Allows us to
remove the workaround for the first render animation glitch. Simpler all
around.
And fix width at 756, which I think should be enough for 80 columns in
the editor. If not, we'll adjust.
...and fix shadow var.
@gordonbrander gordonbrander marked this pull request as ready for review October 4, 2024 14:48
@gordonbrander gordonbrander changed the title Begin work on Common OS skeleton Initial work on Common OS skeleton Oct 4, 2024
@gordonbrander gordonbrander merged commit 8424216 into main Oct 4, 2024
@gordonbrander gordonbrander deleted the 2024-09-26-app-skeleton branch October 4, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OS skeleton and sidebar

2 participants